node deps: add support for interface broadcast addresses

Checklist

[x] make -j4 test (UNIX), or vcbuild test (Windows) passes
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message follows commit guidelines

Oct 12 '18 02:10 pprindeville

Hi! Could you open a pull request against https://github.com/libuv/libuv/ with the libuv changes first? We generally avoid doing our own patches on top of libuv releases. (The libuv part also looks semver-major, which may be a challenge on its own.)

Oct 12 '18 02:10 addaleax

There are existing discussions in libuv/libuv#158 and libuv/libuv#1371 about extending libuv's support for network interfaces.

Oct 12 '18 03:10 richardlau

Hi! Could you open a pull request against https://github.com/libuv/libuv/ with the libuv changes first? We generally avoid doing our own patches on top of libuv releases. (The libuv part also looks semver-major, which may be a challenge on its own.)

Done. See https://github.com/libuv/libuv/pull/2033.

Oct 13 '18 20:10 pprindeville

There are existing discussions in libuv/libuv#158 and libuv/libuv#1371 about extending libuv's support for network interfaces.

I saw those, and from what I can tell they deal with larger architectural issues, like getting addresses for non-IP families, interfaces with no layer-3 configuration, etc. That's a bit orthogonal to what I'm doing here.

Oct 13 '18 21:10 pprindeville

I managed to get this (src/node_os.cc) to compile against libuv/master with my changes, even if there were other files that wouldn't build... was not able to test run, however.

Oct 21 '18 22:10 pprindeville

Currently it returns the empty string

Oct 22 '18 19:10 pprindeville

how do we move forward on this one?

Dec 01 '20 11:12 gireeshpunathil

heya @pprindeville! any chance you're going to pick this up again? No worries if not.

If not, anyone else?

If not... we should probably close this out.

Jan 07 '22 23:01 bnb

heya @pprindeville! any chance you're going to pick this up again? No worries if not.

If not, anyone else?

If not... we should probably close this out.

I can try, but I'm not entirely sure what the blocker is. What do I need to do that I haven't done, or redo, in order to advance this?

Jan 08 '22 01:01 pprindeville

@pprindeville it looks like there's an open question (similar to mine!) in https://github.com/libuv/libuv/pull/2033#pullrequestreview-351825407. I'm assuming that if those can get merged in, this can get merged in if I'm reading the PRs correctly. So, ideally, finishing that PR up then coming back to this one once that lands :)

Jan 11 '22 19:01 bnb

@pprindeville I think the PR that was blocking was merged, or I am wrong?

Dec 21 '23 14:12 marco-ippolito

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

Sep 24 '24 00:09 github-actions[bot]

@pprindeville This PR hasn't had any activity for a while (and the stalebot isn't up), so I've marked this as stalled. Feel free to continue work, if you still would like to persue this PR.

Sep 24 '24 00:09 avivkeller

@pprindeville This PR hasn't had any activity for a while (and the stalebot isn't up), so I've marked this as stalled. Feel free to continue work, if you still would like to persue this PR.

Yeah, after 6 years, whatever expectation of progress I had has dwindled.

Sep 24 '24 02:09 pprindeville