node-v8 icon indicating copy to clipboard operation
node-v8 copied to clipboard
verified publisher icon nodejs

Review state of canary in CI

Open targos opened this issue 2 years ago • 12 comments

Previous thread: https://github.com/nodejs/node-v8/issues/244

targos avatar Apr 17 '23 11:04 targos

Commit: https://github.com/nodejs/node-v8/commit/bc4174881a4074548fb3ba66ef802f14273d9422 CI: https://ci.nodejs.org/job/node-test-commit/61701/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5322/

targos avatar Apr 17 '23 11:04 targos

Relevant diff for the trap handler stuff:

diff --git a/BUILD.gn b/BUILD.gn
index cdbef4ad38..bca193c467 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -4042,9 +4054,10 @@ v8_header_set("v8_internal_headers") {
       sources += [ "src/execution/arm64/pointer-authentication-arm64.h" ]
     }
     if (v8_enable_webassembly) {
-      # Trap handling is enabled on arm64 Mac and in simulators on x64 on Linux
-      # and Mac.
-      if ((current_cpu == "arm64" && (is_mac || is_ios)) ||
+      # Trap handling is enabled on arm64 Mac and Linux and in simulators on
+      # x64 on Linux and Mac.
+      if ((current_cpu == "arm64" &&
+           (is_linux || is_chromeos || is_mac || is_ios)) ||
           (current_cpu == "x64" && (is_linux || is_chromeos || is_mac))) {
         sources += [ "src/trap-handler/handler-inside-posix.h" ]
       }
@@ -5273,9 +5286,9 @@ v8_source_set("v8_base_without_compiler") {
       "src/regexp/arm64/regexp-macro-assembler-arm64.cc",
     ]
     if (v8_enable_webassembly) {
-      # Trap handling is enabled on arm64 Mac and in simulators on x64 on Linux,
-      # Mac, and Windows.
-      if ((current_cpu == "arm64" && is_apple) ||
+      # Trap handling is enabled on arm64 Mac and Linux and in simulators on
+      # x64 on Linux, Mac, and Windows.
+      if ((current_cpu == "arm64" && (is_linux || is_chromeos || is_apple)) ||
           (current_cpu == "x64" && (is_linux || is_chromeos || is_mac))) {
         sources += [
           "src/trap-handler/handler-inside-posix.cc",

targos avatar Apr 17 '23 12:04 targos

Commit: https://github.com/nodejs/node-v8/commit/86b6770e1a1a1ca5bd4353e95ae75de434b52d8c CI: https://ci.nodejs.org/job/node-test-commit/61874/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/5337/

targos avatar Apr 25 '23 12:04 targos

Commit: https://github.com/nodejs/node-v8/commit/aa670d9d71e9bedff24b75e98b02b32819282dde CI: https://ci.nodejs.org/job/node-test-commit/61902/

targos avatar Apr 26 '23 20:04 targos

Commit: https://github.com/nodejs/node-v8/commit/49db4ec7b4a5bb41b2995275c1fec87bb5b61c64 CI: https://ci.nodejs.org/job/node-test-commit/62135/

targos avatar May 07 '23 09:05 targos

Commit: https://github.com/nodejs/node/commit/bca67b72cecf1dc4598f95e0902074cdc55d0655 CI: https://ci.nodejs.org/job/node-test-commit/64501/

targos avatar Sep 06 '23 12:09 targos

Commit: https://github.com/nodejs/node-v8/commit/15d0154b9e1fe6f18ff4e89c3b0be598fcae3260 CI: https://ci.nodejs.org/job/node-test-commit/64680/

targos avatar Sep 13 '23 08:09 targos

Commit: https://github.com/nodejs/node-v8/commit/254e9e6d1a7990e02502c74cc83b3347171015f9 CI: https://ci.nodejs.org/job/node-test-commit/66313/

targos avatar Nov 04 '23 12:11 targos

Commit: https://github.com/nodejs/node-v8/commit/1b0759c6a11c18d7c8100d6e4a898a6ea588d2d0 CI: https://ci.nodejs.org/job/node-test-commit/66582/

targos avatar Nov 15 '23 14:11 targos

Commit: https://github.com/nodejs/node-v8/commit/e16f3d5068af8523d31ede55e7d1d56f90ee173b CI: https://ci.nodejs.org/job/node-test-commit/67540/

targos avatar Dec 22 '23 09:12 targos

Commit: https://github.com/nodejs/node-v8/commit/659bdc3e370d3f637de03c46a16429cd44b17d31 CI: https://ci.nodejs.org/job/node-test-commit/67849/

targos avatar Jan 09 '24 07:01 targos

Commit: https://github.com/nodejs/node-v8/commit/cd9cce4ab98dc5dea3eb1ecfda5691ca0f1507ae CI: https://ci.nodejs.org/job/node-test-commit/67867/

targos avatar Jan 10 '24 13:01 targos