node-report icon indicating copy to clipboard operation
node-report copied to clipboard
verified publisher icon nodejs

Escape version strings passed to regular expression matchers

Open richardlau opened this issue 4 years ago • 2 comments

Version strings in process.versions should be escaped before being used to construct regular expressions. Fixes tests when run against current Node.js master branch where OpenSSL has a + character in its version string.

Refs: https://github.com/nodejs/citgm/issues/852#issuecomment-803261289

richardlau avatar Mar 21 '21 00:03 richardlau

CI: https://ci.nodejs.org/view/post-mortem/job/test-nodereport/41/ (:heavy_check_mark:)

richardlau avatar Mar 21 '21 00:03 richardlau

CI against master showing failures with Node.js 15: https://ci.nodejs.org/job/nodereport-continuous-integration-latest/219/ CI against this PR with Node.js 15: https://ci.nodejs.org/job/nodereport-continuous-integration-latest/222/ Single failure on AIX, which is unrelated to this PR and is the same as we see in the citgm-smoker-nobuild job: https://github.com/nodejs/build/issues/2558.

richardlau avatar Mar 21 '21 00:03 richardlau