feat(gyp): update gyp to v0.12.1

Open dmabupt opened this issue 3 years ago • 4 comments

Related PR: #2626

Apr 11 '22 02:04 dmabupt

LGTM. We could jump straight to gyp-next 0.12.1.

Hello @richardlau , I have updated it to v0.12.1. But there are lots of ci failures.

Apr 15 '22 01:04 dmabupt

Duplicated PR -- https://github.com/nodejs/node/commit/b99bb57416f5eabc9d8375b93e03de21d8ed29ee Close this.

Apr 18 '22 02:04 dmabupt

Duplicated PR -- https://github.com/nodejs/node/commit/b99bb57416f5eabc9d8375b93e03de21d8ed29ee

but that PR is on nodejs/node, not nodejs/node-gyp, so I think we're still in need of a gyp-next upgrade here aren't we?

Apr 19 '22 11:04 rvagg

Yes, we still need this PR. @dmabupt can you please re-open?

Apr 22 '22 16:04 kadler

This can be closed in favor of #2626, which now also updates gyp from gyp-next 0.13.0

Aug 18 '22 15:08 kadler

Close this issue due to https://github.com/nodejs/node-gyp/pull/2626

Sep 19 '22 06:09 dmabupt