node-gyp icon indicating copy to clipboard operation
node-gyp copied to clipboard
verified publisher icon nodejs

Add Visual Studio Build Tools 2017 on README

Open Lucienest opened this issue 4 years ago • 1 comments

Added Visual Studio Build Tools 2017 link as suggested for Windows.

Launch cmd, npm config set msvs_version 2017

Checklist
  • [x] npm install && npm test passes
  • [x] tests are included
  • [x] documentation is changed or added
  • [x] commit message follows commit guidelines
Description of change

Lucienest avatar Dec 24 '21 14:12 Lucienest

I sense that narrowcasting on 2017 misses the point: https://github.com/nodejs/node-gyp/blob/master/gyp/pylib/gyp/MSVSVersion.py#L442-L451

cclauss avatar Dec 24 '21 15:12 cclauss

Closing because this section has all been rewritten and npm config set msvs_version 2017 no longer works on modern versions of npm.

cclauss avatar Apr 12 '24 06:04 cclauss