node-gyp icon indicating copy to clipboard operation
node-gyp copied to clipboard

Fix escaping -I includes when path contains spaces

Open salomvary opened this issue 9 years ago • 6 comments

Fixes #65

salomvary avatar Oct 18 '16 19:10 salomvary

We've been hit by this issue today and were quite surprised to discover it's an ancient bug in node-gyp. Any reason why this can't be merged and #65 fixed?

jure avatar Jul 21 '17 16:07 jure

Hadn't seen this until today but it's at best a partial fix for #65. I didn't do a full audit but things like linker paths and source lists are also affected and probably more.

bnoordhuis avatar Jul 21 '17 21:07 bnoordhuis

Thanks for looking at this! Unless the partial fix breaks something else, and it doesn't seem likely, perhaps it's a good step into the direction of supporting spaces in build paths? The alternative could be a clear notice somewhere in the README, noting the lack of support.

jure avatar Jul 22 '17 09:07 jure

Any news about this? I can't install gyp because I have a space in my hdd name

elmagow avatar Nov 09 '18 13:11 elmagow

@refack should we pursue this here or https://github.com/refack/GYP, I don't even know anymore

rvagg avatar Jun 21 '19 03:06 rvagg

Please get this space thing fixed - super annoying if testing infrastructure contains spaces ... u know to test stability for spaces :D

Schwaller avatar Jun 17 '21 09:06 Schwaller