node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

v8: add ittapi as V8 dependency

Open fanchenkong1 opened this issue 4 years ago • 2 comments

Pull Request check-list

  • [x] This change passed 'npm test' and 'npm run test-all.'
  • [x] This change passed 'npm run lint'.

Description of change

This change add ittapi to the V8 dependency list. The ittapi library is used in V8 to profile JIT-compiled JavaScript code and support instrumentation for JavaScript code.

Refs: https://github.com/nodejs/node/pull/39374

fanchenkong1 avatar Jul 14 '21 04:07 fanchenkong1

Codecov Report

Merging #552 (bfb71f8) into main (f2f77dd) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files          35       35           
  Lines        1750     1750           
=======================================
  Hits         1445     1445           
  Misses        305      305           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f2f77dd...bfb71f8. Read the comment docs.

codecov[bot] avatar Jul 14 '21 04:07 codecov[bot]

Thanks, will merge after https://github.com/nodejs/node/pull/39374 has landed.

targos avatar Jul 14 '21 06:07 targos