node-core-utils
node-core-utils copied to clipboard
git node land issue with PR with benchmark CI
$ git node land 36527
✔ Done loading data for nodejs/node/pull/36527
----------------------------------- PR info ------------------------------------
Title v8: refactor to use more primordials (#36527)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch aduh95:v8-primordials -> nodejs:master
Labels author ready, lib / src, tools
Commits 3
- v8: refactor to use more primordials
- fixup! v8: refactor to use more primordials
- fixup! v8: refactor to use more primordials
Committers 1
- Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/36527
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Pooja D P <[email protected]>
--------------------------------------------------------------------------------
✔ Last GitHub Actions successful
ℹ Last Benchmark CI on 2020-12-17T17:58:12Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/761/
ℹ Last Full PR CI on 2020-12-16T15:14:24Z: https://ci.nodejs.org/job/node-test-pull-request/34968/
⠸ Querying API for job/node-test-pull-request/761/ ✔ Last Jenkins CI successful
ℹ This PR was created on Tue, 15 Dec 2020 14:50:35 GMT
✔ Approvals: 2
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36527#pullrequestreview-553764625
✔ - Pooja D P (@PoojaDurgad): https://github.com/nodejs/node/pull/36527#pullrequestreview-555455402
--------------------------------------------------------------------------------
? This PR should be ready to land, do you want to continue? Yes
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
⠙ Querying API for job/node-test-pull-request/761/
After "Querying API for job/node-test-pull-request/761/", the script just hangs.
I have the exact same issue now on a PR without benchmark CI.
❯ NCU_VERBOSITY=debug git node land 40675
[DEBUG] [SpawnSync] git config --get remote.upstream.url { cwd: '/Users/panva/repo/node' }
[DEBUG] [SpawnSync] git rev-parse --abbrev-ref HEAD { cwd: '/Users/panva/repo/node' }
[DEBUG] [SpawnSync] git rev-parse --abbrev-ref HEAD { cwd: '/Users/panva/repo/node' }
[DEBUG] [fetch] https://api.github.com/graphql
[DEBUG] [SpawnSync] git config --get remote.upstream.url { cwd: '/Users/panva/repo/node' }
⠋ Loading data for nodejs/node/pull/40675
[DEBUG] [fetch] https://raw.githubusercontent.com/nodejs/node/HEAD/README.md
[DEBUG] [fetch] https://api.github.com/graphql
[DEBUG] [fetch] https://api.github.com/graphql
[DEBUG] [fetch] https://api.github.com/graphql
[DEBUG] [fetch] https://api.github.com/graphql
✔ Done loading data for nodejs/node/pull/40675
----------------------------------- PR info ------------------------------------
Title src,crypto: refactor `crypto_tls.*` (#40675)
Author Darshan Sen <[email protected]> (@RaisinTen)
Branch RaisinTen:src,crypto/refactor-crypto_tls -> nodejs:master
Labels crypto, c++, author ready, commit-queue
Commits 1
- src,crypto: refactor `crypto_tls.*`
Committers 1
- Darshan Sen <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40675
Reviewed-By: Anna Henningsen <[email protected]>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 31 Oct 2021 15:15:39 GMT
✔ Approvals: 1
✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/40675#pullrequestreview-795054510
✔ Last GitHub Actions successful
ℹ Last Full PR CI on 2021-11-07T09:48:41Z: https://ci.nodejs.org/job/node-test-pull-request/40684/
⠋ Querying data for job/node-test-pull-request/40684/ ✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
⠦ Querying API for job/node-test-pull-request/40684/
❯ ncu-ci --version
1.30.0
I think this was resolved by https://github.com/nodejs/node-core-utils/commit/35ef99ff0afe0478f26b2028dbcd3170975ede6b. Closing, please reopen if I missed something.