node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

Should retrieve more than the last 10 checkSuites

Open mmarchini opened this issue 5 years ago • 5 comments

We have 12 check suites today on Node.js, which means we're not retrieving all suites to check if they passed (well, after #469 lands). We're retrieving 100 commits for the PR, which is unlikely to happen, so it's probably a good idea to shift from commits to checkSuites (maybe 25 commits / 40 check suites).

mmarchini avatar Aug 15 '20 04:08 mmarchini

Maybe still 50 commits? V8 updates often come close to 25.

targos avatar Aug 15 '20 09:08 targos

Yeah, I'll tweak with it to use the graphql fetch limit (we'll probably go over 20 actions at some point). Although I'm not sure we use the commits (except the last) on any checks.

mmarchini avatar Aug 15 '20 09:08 mmarchini

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Nov 14 '20 00:11 github-actions[bot]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Feb 13 '21 00:02 github-actions[bot]

@mmarchini mind if i do this?

codebytere avatar Feb 17 '21 17:02 codebytere

Fixed by https://github.com/nodejs/node-core-utils/commit/e98d72ef49d32d8b8a0605cce222cb8aaab8c128

aduh95 avatar Mar 11 '23 00:03 aduh95