node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

If last CI is still running, `git node land --yes` should fail

Open mmarchini opened this issue 5 years ago • 1 comments

git node land --yes checks will succeed and advance if last CI is still running, which opens the door for landing PRs before we get a result from our CI. We should change it so that if the CI is still running, git node land will fail.

mmarchini avatar Jun 28 '20 00:06 mmarchini

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Sep 26 '20 00:09 github-actions[bot]

IIUC this has been fixed already, as I see errors when trying to run git node land --yes on a PR whose CI is still running.

aduh95 avatar Mar 10 '23 23:03 aduh95