node-core-utils icon indicating copy to clipboard operation
node-core-utils copied to clipboard

color prs purple

Open devsnek opened this issue 7 years ago • 7 comments

from the collab guide:

Optional: When landing your own commits, force push the amended commit to the
branch you used to open the pull request. If your branch is called `bugfix`,
then the command would be `git push --force-with-lease origin master:bugfix`.
When the pull request is closed, this will cause the pull request to
show the purple merged status rather than the red closed status that is
usually used for pull requests that weren't merged.

devsnek avatar Jul 16 '18 15:07 devsnek

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Aug 16 '20 00:08 github-actions[bot]

ping

ljharb avatar Aug 16 '20 05:08 ljharb

Hopefully we can get this working with the new commit-queue

mmarchini avatar Aug 17 '20 16:08 mmarchini

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Nov 16 '20 00:11 github-actions[bot]

bump

ljharb avatar Nov 16 '20 00:11 ljharb

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Feb 15 '21 00:02 github-actions[bot]

bump forever

ljharb avatar Feb 15 '21 01:02 ljharb

I think we can close this, the CQ is able to purple merge PRs that land one commit, the current workflow seems to be an appropriate compromise.

aduh95 avatar Mar 11 '23 00:03 aduh95