node-chakracore icon indicating copy to clipboard operation
node-chakracore copied to clipboard

Make node-chakracore work with depd

Open kunalspathak opened this issue 8 years ago • 0 comments

  • Version:
  • Platform:
  • Subsystem:

Recently in https://github.com/expressjs/body-parser/pull/233 it was found out that node-chakracore doesn't work with depd module and one of the test fails. Below is the short repro code I extracted from the failing unit test of nodejs-depd repo. The reason is because we have few TODOs for various APIs on StackFrame that needs to be implemented.

var assert = require('assert')
var basename = require('path').basename
var libs = require('./fixtures/libs')
var mylib = libs.my
var captureStderr = require('./support/capture-stderr')

function callold () { eval('mylib.old()') } // eslint-disable-line no-eval
var stderr = captureStderr(callold);
console.log(stderr);

Expected output:

Fri, 04 Aug 2017 22:26:43 GMT my-lib deprecated old at eval at callold (F:\git\nodejs-depd\test\chakratest.js:7:23), <anonymous>:1:7

Actual output:

Fri, 04 Aug 2017 22:26:23 GMT my-lib deprecated old at eval code:1:1

kunalspathak avatar Aug 04 '17 22:08 kunalspathak