node-addon-examples icon indicating copy to clipboard operation
node-addon-examples copied to clipboard

warning when building example

Open calvinmetcalf opened this issue 6 years ago • 1 comments

when building example 6 with nan I get

  CXX(target) Release/obj.target/addon/myobject.o
../myobject.cc:24:3: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result]
  exports->Set(context,
  ^~~~~~~~~~~~ ~~~~~~~~
1 warning generated.

calvinmetcalf avatar Dec 10 '19 13:12 calvinmetcalf

hi @calvinmetcalf thanks for report this. but I can't see this warning anymore (tested with node v12.19.1).

make: Entering directory '/home/hf/code/napi/node-addon-examples/6_object_wrap/node-addon-api/build'
  CXX(target) Release/obj.target/addon/addon.o
  CXX(target) Release/obj.target/addon/myobject.o
  SOLINK_MODULE(target) Release/obj.target/addon.node
  COPY Release/addon.node
make: Leaving directory '/home/hf/code/napi/node-addon-examples/6_object_wrap/node-addon-api/build'
audited 2 packages in 3.122s
found 0 vulnerabilities
$ node --version
v12.19.1

Should this issue be closed?

helio-frota avatar Nov 20 '20 12:11 helio-frota