node-addon-api icon indicating copy to clipboard operation
node-addon-api copied to clipboard

Discussion: Formatting inconsistency in markdown documentation

Open KevinEady opened this issue 1 year ago • 3 comments

Some documented methods have the C++ definition before the description:

https://github.com/nodejs/node-addon-api/blob/b8525e2f8ca8887c5ec864706c27b8872a5a6256/doc/env.md?plain=1#L87-L104

... while others have the description before the C++ definition:

https://github.com/nodejs/node-addon-api/blob/b8525e2f8ca8887c5ec864706c27b8872a5a6256/doc/addon.md?plain=1#L144-L161

For some rough stats, it seems to be split almost evenly... Searching for ### .+\n+``` (ie. definition first) gives 208 results, while ### .+\n+\w (ie. description first) gives 219 results.

Do we have a preference? Does it matter?

KevinEady avatar Jul 04 '24 10:07 KevinEady

We should check the Node.js api docs in nodejs/node/doc/api to see which it does and likely follow that.

mhdawson avatar Jul 05 '24 13:07 mhdawson

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Oct 04 '24 00:10 github-actions[bot]

Personally, I would prefer having documentation above the definition specifically because having a context on what you are reading makes it easier to understand and analyze.

Bucksmon avatar Oct 25 '24 09:10 Bucksmon

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

github-actions[bot] avatar Jan 24 '25 00:01 github-actions[bot]