nodejs
fix: handle removed `IdleNotificationDeadline`
See https://chromium-review.googlesource.com/c/v8/v8/+/5539852 - this has been removed upstream and will no longer build on newer V8 versions.
Thabk you. Looks good at a glance. I shall take a closer look soon when I have a chance.
On May 20, 2025 11:10:00 AM GMT+03:00, Shelley Vohr @.***> wrote:
See https://chromium-review.googlesource.com/c/v8/v8/+/5539852 - this has been removed upstream and will no longer build on newer V8 versions.
You can view, comment on, or merge this pull request online at:
https://github.com/nodejs/nan/pull/999
-- Commit Summary --
- fix: handle removed IdleNotificationDeadline
-- File Changes --
M nan.h (7)
-- Patch Links --
https://github.com/nodejs/nan/pull/999.patch https://github.com/nodejs/nan/pull/999.diff
-- Reply to this email directly or view it on GitHub: https://github.com/nodejs/nan/pull/999 You are receiving this because you are subscribed to this thread.
Message ID: @.***>
Could you explain why this is needed now? V8 11.something is already older than the 12.7 when it was removed. Is that when the deprecation warning was introduced?
@kkoopa yes - i based the numbers off https://github.com/nodejs/nan/issues/953#issuecomment-1791163429 which is where the notice was introduced. I changed it to 12.7. Sorry for the delay here!