llnode icon indicating copy to clipboard operation
llnode copied to clipboard

Upcoming metadata changes in V8 7.4

Open cjihrig opened this issue 6 years ago • 2 comments

The V8 7.4 update requires the following adjustments to the postmortem debugging metadata constants:

  • v8dbg_class_FixedTypedArrayBase__external_pointer__Object
    • Type changed in https://github.com/v8/v8/commit/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8#diff-f3f182b0510ba2ee39ae87e421ff110b.
    • Use v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t
  • v8dbg_class_JSArrayBuffer__backing_store__Object and v8dbg_class_JSArrayBuffer__byte_length__Object
    • Type changed in https://github.com/v8/v8/commit/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8#diff-f3f182b0510ba2ee39ae87e421ff110b.
    • Use v8dbg_class_JSArrayBuffer__backing_store__uintptr_t and v8dbg_class_JSArrayBuffer__byte_length__size_t
  • v8dbg_class_Map__raw_instance_descriptors__DescriptorArray
    • Changed in https://github.com/v8/v8/commit/d7b08b6da2fd963ab7f74319617050329881a8c2#diff-59788e25dc5196c356894d5e1fac6425
    • New constant added to V8: v8dbg_class_Map__instance_descriptors_offset
  • ~~v8dbg_PointerSizeLog2~~ (done in #300)
    • Changed in https://github.com/v8/v8/commit/46d1986812097f712aa7c314c8aa49ec49a33b88#diff-f3f182b0510ba2ee39ae87e421ff110b
    • Refs: https://bugs.chromium.org/p/v8/issues/detail?id=8477
    • Use new constants: v8dbg_SystemPointerSize, v8dbg_SystemPointerSizeLog2, v8dbg_TaggedSize, and v8dbg_TaggedSizeLog2

Refs: https://github.com/nodejs/node/pull/26685

cjihrig avatar Mar 28 '19 13:03 cjihrig

Related change: https://github.com/v8/v8/commit/9a149afc28055e36b00e978b78ccb8f9acc15b60

(I should start to update our Node.js postmortem tests when I use new constants here :stuck_out_tongue: )

mmarchini avatar Apr 01 '19 23:04 mmarchini

This seems related as well: https://chromium-review.googlesource.com/c/v8/v8/+/1278014

mmarchini avatar Oct 04 '19 22:10 mmarchini