un-skipping blake2b-wasm on s390x

[pacostas]

This PR un-skips blake2b-wasm for s390x system architecture, after the recent upgrade of esbuild on wasm-tools (which is a dependency on blake2b-wasm). There is an open PR on blake2b-wasm for upgrading wasm-tools https://github.com/mafintosh/blake2b-wasm/pull/21 although we dont have to wait for the PR to land, due to npm resolves wasm-tools, during blake2b-wasm npm install, from 0.2.0 to 0.2.1

[codecov-commenter]

Codecov Report

Base: 95.16% // Head: 96.27% // Increases project coverage by +1.11% :tada:

Coverage data is based on head (fdea964) compared to base (a35b3fd). Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
+ Coverage   95.16%   96.27%   +1.11%     
==========================================
  Files          28       28              
  Lines        2149     2149              
==========================================
+ Hits         2045     2069      +24     
+ Misses        104       80      -24     

Impacted Files	Coverage Δ
lib/bin/citgm-all.js	95.37% <0.00%> (+0.84%)	:arrow_up:
lib/bin/citgm.js	100.00% <0.00%> (+1.80%)	:arrow_up:
lib/spawn.js	100.00% <0.00%> (+76.92%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[BethGriggs]

Pipeline run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/189/ (on all platforms, but we can just looking to see if s390x now passes)

Edit: properly configured the job 😅

[pacostas]

Appears to pass on s390x now

Yes, esbuild supports s390x

[pacostas]

I thought this PR had been merged. The tests results shows that is failing on node 18, although the logs have expired, so I can't see where exactly. I just tested it on x64, ppc and s390x and all tests passes. @richardlau Can you trigger once more the tests to get the test results ?

[richardlau]

I thought this PR had been merged. The tests results shows that is failing on node 18, although the logs have expired, so I can't see where exactly. I just tested it on x64, ppc and s390x and all tests passes. @richardlau Can you trigger once more the tests to get the test results ?

I don't see a rerun button for those failed actions runs so unfortunately no, I cannot. You may need to rebase onto the current main to trigger a fresh run.

[pacostas]

I thought this PR had been merged. The tests results shows that is failing on node 18, although the logs have expired, so I can't see where exactly. I just tested it on x64, ppc and s390x and all tests passes. @richardlau Can you trigger once more the tests to get the test results ?

I don't see a rerun button for those failed actions runs so unfortunately no, I cannot. You may need to rebase onto the current main to trigger a fresh run.

@richardlau Thank you! the rebase did the trick : ) Can you also merge it?