ember-cli causing CITGM to hard fail on Windows

[BethGriggs]

• Node Version: Multiple
• CitGM Version: Latest
• Platform: Windows

It looks like ember-cli is causing CITGM to hard fail on Windows with the following error:

15:49:13 error: failure             | Test Timed Out      
15:49:17 [Error: EBUSY: resource busy or locked, rmdir 'C:\Users\ADMINI~1\AppData\Local\Temp\dbc0cb80-9c24-40ad-95d1-509c6b6462a7\ember-cli'] {
15:49:17   errno: -4082,
15:49:17   code: 'EBUSY',
15:49:17   syscall: 'rmdir',
15:49:17   path: 'C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\dbc0cb80-9c24-40ad-95d1-509c6b6462a7\\ember-cli'
15:49:17 }

https://ci.nodejs.org/job/citgm-smoker/nodes=win-vs2017/2348/console

I've seen this on v13.x and v14.x. The hard fail means that Windows results do not appear in the aggregated results view, so we're potentially missing some failures.

[richardlau]

I think this is related to https://github.com/nodejs/citgm/issues/779 and is related to tests timing out. We don't kill any child processes spawned by tests when tests time out which may prevent the temp directory CITGM creates to test the module from being removed. I'm not sure if there's a cross-platform way of killing all spawned processes.

We could possibly ignore (but still warn) when we fail to remove the temp directory we create at the end of test run for a module.

[richardlau]

I've not been able to find a cross-platform module to kill a process tree of spawned processes (at best there are modules that support Linux, macOS and Windows but not, for example, AIX).

Raised https://github.com/nodejs/citgm/pull/829 to handle the errors and continue.