nodejs
lookup: add skipIssue as a metadata
I think it would be quite useful to have a reference for each skipped module.
Potentially, we would also want to have flakyIssue for each flaky module as well.
+1 on the idea of having a reference. I'm not convinced it should be in lookup.json though. My preference would be to maintain this in the Skipped modules project which can be easily updated without the need for pull requests.
My preference would be to maintain this in the Skipped modules project which can be easily updated without the need for pull requests.
+1 on this. We could have more then one issue opened, so I guess it would be cleaner if we reference them in the project. I will start working on the project as soon as I get an access.
I think it would make sense to document whatever process we decide on.
On Fri, Feb 23, 2018, 10:53 AM Oleksandr Kushchak [email protected] wrote:
My preference would be to maintain this in the Skipped modules project which can be easily updated without the need for pull requests.
+1 on this. We could have more then one issue opened, so I guess it would be cleaner if we reference them in the project. I will start working on the project as soon as I get an access.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nodejs/citgm/issues/547#issuecomment-368048920, or mute the thread https://github.com/notifications/unsubscribe-auth/AAecV5jj6DchESE2UUSL2VozHpz4qsprks5tXt7ygaJpZM4SRB0T .
I think it would make sense to document whatever process we decide on.
Sure. I can work on a document.
I'm +1 to this. We should definetely document the test failures as we skip modules
@targos
I'm not convinced it should be in lookup.json though.
The problem is that you have to maintain the same thing in two different places. It is just hard to keep them in sync and therefore I would definitely prefer to have that information right next to the code. That is also handy because changes to either flaky or skipped entries would inevitably also mean you edit the text next to it and the other way around.
