changelog-maker icon indicating copy to clipboard operation
changelog-maker copied to clipboard
verified publisher icon nodejs

Stop escaping markdown characters inside code blocks

Open XhmikosR opened this issue 6 years ago • 6 comments

https://github.com/nodejs/nodejs.org/pull/2608#issuecomment-535415349

XhmikosR avatar Sep 26 '19 11:09 XhmikosR

@XhmikosR would you be fine to open a PR to fix this? I think that would be ideal :-)

BridgeAR avatar Sep 26 '19 15:09 BridgeAR

It's tricky so I was hoping someone else could tackle this :)

Otherwise I'll try to find a solution.

XhmikosR avatar Sep 26 '19 15:09 XhmikosR

I've come up with this but I'm not sure if it's the best solution...

https://regex101.com/r/t90Tqw/2

XhmikosR avatar Sep 26 '19 15:09 XhmikosR

I suspect a regexp will never be 100% reliable, but it can probably be sufficiently reliable. 100% reliability would probably require doing proper parsing instead of regexp matching.

Trott avatar Sep 27 '19 05:09 Trott

I don't think my regex is good. I'll see if I can improve it and make a PR.

XhmikosR avatar Sep 27 '19 08:09 XhmikosR

Unfortunately, the project doesn't work on Windows, so I can't do a lot.

XhmikosR avatar Sep 27 '19 09:09 XhmikosR