admin icon indicating copy to clipboard operation
admin copied to clipboard

Heads up: changed required approval settings for actions in the org

Open targos opened this issue 4 years ago • 3 comments

@nodejs/tsc @nodejs/community-committee @nodejs/moderation

I changed the global setting at https://github.com/organizations/nodejs/settings/actions Previous value (GitHub default): "Require approval for first-time contributors" New value: "Require approval for first-time contributors who are new to GitHub"

targos avatar Jul 14 '21 11:07 targos

I'm not opposed, but I am curious to know what was the motivation for the change?

Trott avatar Jul 14 '21 11:07 Trott

In nodejs/node, I had to manually approve workflow runs on several pull requests that were open for many weeks. GitHub recently introduced this to protect themselves from crypto miners, but I don't think the nodejs org ever got a pull request opened to abuse the system.

targos avatar Jul 14 '21 11:07 targos

In nodejs/node, I had to manually approve workflow runs on several pull requests that were open for many weeks. GitHub recently introduced this to protect themselves from crypto miners, but I don't think the nodejs org ever got a pull request opened to abuse the system.

We did: https://github.com/nodejs/moderation/issues/411

richardlau avatar Jul 14 '21 11:07 richardlau