solid-auth-client icon indicating copy to clipboard operation
solid-auth-client copied to clipboard

Improve generic error handling

Open kjetilk opened this issue 7 years ago • 2 comments

There have been issues with the "Log In" button in the popup being unresponsive. I still have this problem, https://github.com/solid/node-solid-server/issues/884 and others had this problem due to an expired cert.

There should be some kind of feedback to the user in this situation, at least an error that they can go to the forum about. Perhaps there should even be a forum link in the error message if it is very generic?

kjetilk avatar Oct 25 '18 20:10 kjetilk

I think the problem is that the feedback never reaches the client code. Fetchers in the browser are not allowed to see many details about request failures, as these can be exploited.

But I can probably set a timeout that results in an error message.

Can someone post exact steps to reproduce?

RubenVerborgh avatar Oct 26 '18 08:10 RubenVerborgh

Hmmm, but in my case, it happens without any network interaction, and it only happens on my laptop, so it is clearly highly environment dependent... Awfully hard to reproduce... I'll tinker with some plugins and see if that matters, at least.

In JD's case, they had an invalid cert on the WebID provider. Presumably, it can be reproduced simply by having that. These are two very different bugs, but I was hoping there could be some generic fallback error handling...

kjetilk avatar Oct 26 '18 08:10 kjetilk