solid-auth-client icon indicating copy to clipboard operation
solid-auth-client copied to clipboard

FR: typescript defs

Open lukepighetti opened this issue 7 years ago • 4 comments

Hello, just wondering if there is a future with typescript definitions for solid-auth-client. Thanks!

lukepighetti avatar Sep 30 '18 14:09 lukepighetti

The library is currently annotated with Flow, so we'll have to choose one or the other.

That said, would https://github.com/bcherny/flow-to-typescript help?

RubenVerborgh avatar Sep 30 '18 14:09 RubenVerborgh

I have to admit ignorance, is it not possible to have both?

I will check that out as well. Thanks.

lukepighetti avatar Sep 30 '18 14:09 lukepighetti

It's not possible to have both Flow and TypeScript in a source file. It would be possible to have a separate TypeScript type definitions file, but that would be double maintenance given that we already use the Flow typing system.

That said, this is our only Solid library using Flow; things might still change.

RubenVerborgh avatar Sep 30 '18 14:09 RubenVerborgh

It would be nice to add the type definitions to the TypeScript DefinitelyTyped repository. There are already a couple of generators/examples that use Angular and Typescript, so it would make sense having the relative types well defined.

sentenza avatar Oct 09 '18 16:10 sentenza