node-solid-server icon indicating copy to clipboard operation
node-solid-server copied to clipboard

NSS try to create path, filename containing invalid windows characters like colon

Open bourgeoa opened this issue 5 years ago • 4 comments

@timbl @michielbdejong @RubenVerborgh @highlevellogic

Trying NSS on a windows pod https://bourgeoa.solid.hll.nu:7443 . Tested the chat with me from OS solid The function returns a PUT error 500

FAILED to save new chat channel at: https://bourgeoa.solid.hll.nu:7443/IndividualChats/bourgeoa.solid.hll.nu:7443/index.ttl : Web error: 500 (Internal Server Error) on PUT of https://bourgeoa.solid.hll.nu:7443/IndividualChats/bourgeoa.solid.hll.nu:7443/index.ttl

This is due to the colon : in the folderPath

To ensure solid compatibility can we forbid the windows forbidden characters in pathName like \/:*%"<>| ? This could be done in resource-mapper.js Should it be OS dependent to allow any file OS file be URI capable.

index:name.ttl is valid POSIX file and URI, but invalid WINDOWS

bourgeoa avatar Dec 06 '20 15:12 bourgeoa

@jeff-zucker this may have some impact on solid-rest

bourgeoa avatar Dec 06 '20 20:12 bourgeoa

Yes, solid-rest needs to be able to translate requests for valid URLs into valid file names on whatever the backend is.

jeff-zucker avatar Dec 06 '20 21:12 jeff-zucker

Is it necessary for the port to be included in the directory name? What problem would be caused by creating chat directories like account directories, without the port?

highlevellogic avatar Dec 07 '20 08:12 highlevellogic

@highlevellogic see PR https://github.com/solid/chat-pane/pull/50

bourgeoa avatar Dec 08 '20 14:12 bourgeoa