node-solid-server icon indicating copy to clipboard operation
node-solid-server copied to clipboard

docker documentation for config files is no longer valid

Open alastair opened this issue 5 years ago • 6 comments

The docker installation instructions (https://github.com/solid/node-solid-server#use-docker) have a step:

docker cp solid:/usr/src/app/config.json .

However by default this file doesn't exist, I get an error:

Error: No such container:path: solid:/usr/src/app/config.json

I was able to successfully create a config file using solid init and then copy it

perhaps these instructions need to be updated to cover some recent changes to the docker setup?

alastair avatar Jul 23 '20 09:07 alastair

Thanks for raising the issue. The problem comes from the introduction of a solid docker image, which uses a different home folder (opt/solid/) than the original dockerfile (usr/src/app/).

Something should be updated. @angelo-v what do you think : change the documentation or align docker image and dockerfile ?

  • align docker image and dockerfile has a big draw back : both are used in production
  • then change the documentation, may be the only feasible solution.

bourgeoa avatar Jul 23 '20 12:07 bourgeoa

We should clarify in the documentation, that the docker image is configured via environment variables (as it is common with docker). The config.json should not be used at all

angelo-v avatar Jul 28 '20 15:07 angelo-v

Thanks for the comment. This helpfully answers my questions in https://github.com/solid/node-solid-server/issues/1453 too

alastair avatar Jul 29 '20 07:07 alastair

@angelo-v wrote:

The config.json should not be used at all

That's in direct contradiction to the current docs! (scroll up one paragraph from the header to which this links)

Configuring Solid via the config file can be a concise and convenient method and is the generally recommended approach.

(Quite likely, this should be combined with #1453.)

TallTed avatar Nov 09 '20 18:11 TallTed

You are referring to a paragraph that is not about docker usage. My statement that you quote is about docker usage only.

angelo-v avatar Nov 09 '20 18:11 angelo-v

@angelo-v -- Ah, sorry, my mis-read. :-(

TallTed avatar Nov 12 '20 19:11 TallTed