bus-starter icon indicating copy to clipboard operation
bus-starter copied to clipboard

Fixing a bug in the starter until the workflow is correctly construct…

Open Roustalski opened this issue 4 years ago • 2 comments

We were getting ready to write an enterprise bus messaging queue from scratch because we didn't think anything existed for TS already, but we were excited to find node-ts/*!

Anyway, we saw that you recently removed InversifyJS as a hard dependency. Sad, but I understand the reasoning (We just InversifyJS extensively). The removal caused an issue with the starter, so I temporarily setup the bus with a container using Inversify in main until you guys work out how to get a bus instance to the workflows internally.

Roustalski avatar Oct 21 '21 01:10 Roustalski

Hey @Roustalski - thanks heaps for raising this!

The choice to remove inversify was a tough one, but I felt it's better to let developers choose if they want to use DI and if so choose the DI lib they're comfortable with.

I've fixed the bus reference in https://github.com/node-ts/bus-starter/pull/27 and added a much needed test in an effort to prevent this library forcing the use of inversify on everyone.

Cheers

adenhertog avatar Oct 21 '21 23:10 adenhertog

Hey @Roustalski I tried responding to your email but looks like there's a problem with the server

Screenshot_2021-10-31-15-49-18-970_com google android gm

adenhertog avatar Oct 31 '21 05:10 adenhertog