node-red
Editor: Change- deploy - undo - deploy fails to mark dirty badges & activate `Deploy` button
Current Behavior
This appears to be a flaw in the deploy point creation or detection engine whereby two flows states are both treated as the current deployment state. Also, node dirty markers don't seem to appear at all when using the undo history.
Expected Behavior
- Dirty markers on nodes (blue disc) should reappear during the entire undo/redo process if said node differs from live flows state.
- Deploying then redoing should never grey out the Deploy button.
Steps To Reproduce
- Open an extant install (with stuff on it) and deploy.
- Add some stuff to flow and deploy again.
- Undo the actions from step 2, and deploy a third time.
- Redo up the actions from step 2 and notice the Deploy button greys out again even though the live Editor state does not match the active Deploy state anymore.
Example flow
simple to reproduce
Environment
- Node-RED version: 4.1.0
- Node.js version:
- npm version:
- Platform/OS: macOS
- Browser: Chrome
Thank you! Just confirming that you reproduced both bugs here (Deploy button issue as well as blue discs dirty markers not appearing at all anywhere during the undo/redo processes)
The fix in #5352 fixes some of the reported issue, but not all of it. I'm investigating the second part - node's not showing the change marker after a post-deploy undo.
I can see what's happening, but it needs a bit more effort to unpick properly due to the way the flags are reset on deploy. Hoped to get this done for 4.1.2, but some recent dependency CVEs have pushed up the need to get that release done. Will come back to this.
Thanks for looking into it! I'm not certain if it's a different system or anything, but just want to point out that flow/subflow tabs (the tab graphic itself atop the Editor, that is) also fail to get their dirty markers properly, in a similar way to nodes. I imagine that's all part of the same system, but just in case.