node_pcap icon indicating copy to clipboard operation
node_pcap copied to clipboard

bssid, shost & dhost in wrong order for 802.11 frame

Open fridaystreet opened this issue 9 years ago • 2 comments

In radio_frame.js from line 57, it appears the mac addresses are in the wrong order.

Current order is bssid, shost, dhost

this.bssid = new EthernetAddr(raw_packet, offset); offset += 6; this.shost = new EthernetAddr(raw_packet, offset); offset += 6; this.dhost = new EthernetAddr(raw_packet, offset); offset += 6;

Should be dhost, shost, bssid

this.dhost = new EthernetAddr(raw_packet, offset); offset += 6; this.shost = new EthernetAddr(raw_packet, offset); offset += 6; this.bssid = new EthernetAddr(raw_packet, offset); offset += 6;

fridaystreet avatar Jun 06 '16 01:06 fridaystreet

I could make a pull request or you can use my fork for this specific issue.

marcelmaatkamp avatar Jun 09 '16 12:06 marcelmaatkamp

Thanks Marcel,

Probably best to do a pull request if you can, that way it's easier to maintain future updates. I'll use yours in the mean time.

Cheers Paul

fridaystreet avatar Jun 10 '16 01:06 fridaystreet