tamsin woo

Results 113 comments of tamsin woo

starting with flaky tests listed here https://app.circleci.com/insights/github/samvera/hyrax/workflows/ruby2-7/tests

`docker-compose exec -w /app/samvera/hyrax-engine app sh -c "bundle exec rspec /app/samvera/hyrax-engine/spec/jobs/valkyrie_ingest_job_spec.rb:40` fails consistently for me on a `.dassie` container environment. it looks like this test is maybe a little forced...

here's my take: 1. i'm not convinced that adding these methods moves us away, in any meaningful way, from the DataMapper pattern. to the extent we're departing from DataMapper, it...

is this still a backport we want?

i'd like to move the discussion from https://github.com/samvera/hyrax/pull/6145#issuecomment-1672410956 over here.

> am i understanding correctly that: > > * people added to administrative sets do not get access to existing works > > * people removed from administrative sets do...

could this whole column just be dropped? i'm not sure i understand it's function if the ON/OFF gives the current status.

@rjkati we would love feedback on these designs before taking a stab at implementing

This might be a use case for `RDF::Transaction`. We'd have to add a `#changed?` API, but that seems like a nice feature add if we could get it right. The...

is this due to the inclusion of `Reform::Form::ActiveModel`? are there other methods included from Reform that will dead-end this way?