happly icon indicating copy to clipboard operation
happly copied to clipboard

common case helper for texture UVs added

Open EgeCiklabakkal opened this issue 6 years ago • 2 comments

EgeCiklabakkal avatar Apr 18 '19 10:04 EgeCiklabakkal

Hi, thanks for opening this pull request!

I totally support the adding these UV common-case helpers, but I think a few changes might be needed compared with this strategy.

  • If there are no UV properties, we should throw an error. This might not be the best behavior, but it should be consistent with other functions like getVertexColor()
  • All-zero UVs probably shouldn't get special treatment in the library, that can be handled in the user's application
  • We should probably check a few common names for UV's, I've seen s and t as well for instance.

nmwsharp avatar Aug 17 '19 20:08 nmwsharp

Is this pr salvageable? Can you propose tasks?

fire avatar Jan 19 '22 01:01 fire