happly icon indicating copy to clipboard operation
happly copied to clipboard

getVertexPositions as template function

Open brezhnyev opened this issue 5 years ago • 1 comments

brezhnyev avatar May 22 '20 19:05 brezhnyev

Hi! Thank you for the pull request.

This seems reasonable, though can you add a default version so that existing code that just calls getVertexPositions() still works? Perhaps something like:

std::vector<std::array<double, 3>> getVertexPositions(
    const std::string& vertexElementName = "vertex") {

    return getVertexPositions<double>(vertexElementName);

}

(I feel like there ought to be some way to do this with a typedef/using, but I don't know what it is)

This should also get the CI test above to pass.

nmwsharp avatar Jun 01 '20 17:06 nmwsharp