ss3-source-code icon indicating copy to clipboard operation
ss3-source-code copied to clipboard

[refactor]: review GitHub labels and remove/edit/add

Open e-perl-NOAA opened this issue 2 years ago • 0 comments

Issue description

I have reviewed the stock-synthesis repo labels and saw that some don't have issues/PRs linked or have very few. Thought a review of the current labels might be warranted and wanted to get others thoughts. Not a major or pressing issue. Feel free to edit the table as you see fit or provide feedback in the comments.

Labels

label # of open issues & PRs # of closed issues & PRs suggested action/question
admb 0 0 add
area & movement 6 1 keep
benchmark - MSY 3 7 keep
bioecon 0 2 delete? one of these wasn't an issue after all the other looks more aligned with fleet
biology 2 13 keep
bug 2 39 keep
build 2 9 keep
change log 2 38 keep
code review 5 1 is there a better label for this? nothing has been given this label since 2021
code tuneup 0 2 delete?
composition 5 13 keep
data generator 1 2 is there a better label for this?
discard & retention 0 5 keep
doc 1 8 keep
duplicate 0 6 delete; seems unnecessary to have a duplicate label
essay topic 6 1 could this be combined with doc? maybe "doc & vignettes"?
expected values 1 1 is this a useful label? hasn't been used since 2020
FIMS 4 2 keep
fishing mortality 3 5 keep
fleet characteristics 0 2 delete? maybe rename to just "fleets"?
forecast 5 18 keep
growth 11 2 keep
hard 18 2 keep; maybe rename "effort: hard"
help wanted 0 2 is this a useful label? maybe combine with "question"?
in progress 4 7 keep
initial F 1 2 keep
invalid 0 0 delete
mcmc 0 0 add
misc. input 7 13 keep
misc. internal calc 6 12 keep
misc. output 14 36 keep
natural mortality 1 0 is this a useful label with only 1 issue or PR?
needs testing 2 1 combine with "testing"?
new request 13 15 keep
on hold 3 1 keep; combine with "wait"?
predator 0 5 keep
priority: low 0 0 add
priority: high 0 0 add
question 12 20 keep; maybe combine with "help wanted"?
quick 2 14 maybe rename "effort: easy" or "effort: quick"?
r4ss 1 9 keep
recruitment 12 6 keep
resolved 0 25 do we need this? seems redundant with closing an issue
revision 1 14 ?
run control 1 8 what is meant by run control?
selectivity 3 7 keep
statistics 2 6 keep
tag-recapture 3 3 keep
testing 2 6 maybe combine with "needs testing"?
time-vary parm 4 15 keep
variance 2 5 keep
wait 0 0 delete? there is also "on hold"
warnings 3 12 keep
wishlist 45 21 keep
wont-fix 0 7 delete
workflows 8 27 keep
Epic: Data weighting improvement 2 5 do we need this?
Epic: Equilibrium calcs 1 1 do we need this? not a lot of issues under this label and other labels describe these issues
Epic: Improve bmarks/fcast 2 0 do we need this? could this go under benchmark - MSY or forecast?
Epic: Improve movement 2 0 do we need this? could this just be a movement label?
Epic: Improve parameters 3 1 do we need this? other labels describe these issues well
Epic: Update to ADMB 13 0 3 do we still need this since the update is finished?
Epic: Update to ADMB 13.1 1 3 do we still need this since the update is finished?
Epic: User input options 3 0 do we need this? can this just be misc. input?

Are the "Epic: XX" labels useful to people?

Summary of issue history, discussion, and major aspects of code development

None.

Items to do

  • [ ] SS3 team members to review labels in the table & suggest actions/comment.
  • [ ] @e-gugliotti-NOAA to implement suggested actions

Does documentation already exist in the SS3 User Manual?

Yes, the link to the section in the SS3 User Manual is provided below.

Documentation to add to the SS3 User Manual OR link to existing documentation

None needed; this is related to GitHub.

Are r4ss changes needed?

No, this issue doesn't require changes to r4ss

Are SSI changes needed?

No, this issue doesn't require changes to SSI

e-perl-NOAA avatar Jun 01 '23 19:06 e-perl-NOAA