SSMSE icon indicating copy to clipboard operation
SSMSE copied to clipboard

allow SSMSE to work with SS3.30.21

Open k-doering-NOAA opened this issue 1 year ago • 10 comments

@e-perl-NOAA is working on making SSMSE compatible with SS3.30.21. This is because a user needs a feature that is only available in 3.30.21 and newer.

SSMSE will continue to work and will be distributed with the 3.30.18 binaries. However, users will be able to swap in the 3.30.21 exes instead, if they would like, and should expect SSMSE to work once this issue is completed.

@e-perl-NOAA feel free to add to this/edit if I missed something or got something wrong!

k-doering-NOAA avatar Jun 05 '24 00:06 k-doering-NOAA

i wondering to know if do you have some news about this issue. maybe i pressing a little bit. Takk

MauroMardones avatar Jul 02 '24 14:07 MauroMardones

I made progress on this awhile ago but reached a road block with one of the SSMSE functions that I had to pass on to @k-doering-NOAA to see if she could sort out the issue. I hope :pray: that will be the last step in getting SSMSE working with SS3 v 3.30.21.

e-perl-NOAA avatar Jul 02 '24 14:07 e-perl-NOAA

Cool. i guess is a tricky issue. thanks anyway for the progress. I will be with an eye on.

MauroMardones avatar Jul 02 '24 14:07 MauroMardones

im trying to run the example with 3.30.18 v but this message appear when run cod_1_path <- file.path(run_SSMSE_dir, "cod_SR_BH_steep_1") "sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper sudo: a password is required"

what mean?

MauroMardones avatar Jul 03 '24 15:07 MauroMardones

I ran the example in the README.md on both my local windows machine and on a linux machine using GitHub codespaces but I didn't run into that message. Maybe it's a folder permission issue on your computer.

e-perl-NOAA avatar Jul 05 '24 13:07 e-perl-NOAA

Could it be an issue with the executable? Do I need to manually place it in a specific directory or the function generates it?

MauroMardones avatar Jul 08 '24 08:07 MauroMardones

SSMSE uses the executable that's in the package. You could try changing the permissions of the executable in the package with

sudo chmod a+x path-to-executable-in-ssmse

too see if that does anything.

e-perl-NOAA avatar Jul 08 '24 13:07 e-perl-NOAA

@k-doering-NOAA could you help with this issue before you go on leave? There is just one test (test-interim) that seems to not pass and I'm at a loss as to why. See failed action here with details on failed testthat.

e-perl-NOAA avatar Jul 29 '24 13:07 e-perl-NOAA

I think 06048c5 fixes the interim tests (passes locally for me with an older r4ss version). The failing ghactions are due to #216

k-doering-NOAA avatar Aug 01 '24 18:08 k-doering-NOAA

Merge this in within the next month

k-doering-NOAA avatar Apr 22 '25 21:04 k-doering-NOAA

This is now complete in https://github.com/nmfs-ost/SSMSE/pull/224. Apologies that this took forever to be incorporated! Please report if you try using SSMSE with 3.30.21 and run into any bugs, as we just made sure that the package tests worked with .21 and nothing more.

k-doering-NOAA avatar Jun 09 '25 20:06 k-doering-NOAA