feat: getcharid and getguildinfo base command

[danielhe4rt]

Description

Implementing missing features for Kafra NPC.

To-do

• [x] cutin
• [ ] percentheal
• [ ] viewpoint
• [x] implode
• [ ] countitem
• [ ] delitem
• [x] basicskillcheck
• [ ] getskilllv
• [x] getcharid
• [x] getguildinfo
• [x] savepoint
• [ ] emotion
• [ ] logmes

[danielhe4rt]

@nmeylan There's any easier way to test these commands on compile time?

[danielhe4rt]

And how about commands that isn't implemented at rAthena codebase?

[danielhe4rt]

Nevermind, it belongs to Hercules and not rAthena.

[nmeylan]

@nmeylan There's any easier way to test these commands on compile time?

You mean at build time with test? Unfortunatly i have not setup unit test for this native function handler method, but it would be nice to have. I am afraid that we add more and more feature to this function without tests, it will be harder to catch up

The vm was designed to make testing of scripts easy https://github.com/nmeylan/rathena-script-lang-interpreter/tree/master/tests https://github.com/nmeylan/rathena-script-lang-interpreter/blob/master/tests/native_test.rs#L21

[danielhe4rt]

Are you sure that the function "logmes" is placed in any Kafra's script? I took a look into rAthena and Hercules src's and didn't found anything related there.

Maybe it will have a specific usage that you're planning?