NoahMarkowitz
NoahMarkowitz
@larsoner this one is ready to be merged
@wmvanvliet I created this issue due to the large number of ideas we discussed earlier. We can list PRs here and come up with a step-by-step plan
Some code I made for mne-qt-browser using `TimeChange` event ``` from pathlib import Path import numpy as np import mne from mne.viz.ui_events import TimeChange, link, publish, subscribe mne.viz.set_browser_backend('qt') # 'qt'...
@wmvanvliet I made a draft pull request with this implementation in qt databrowser. Scrolling through time and channels is working. https://github.com/mne-tools/mne-qt-browser/pull/286 Requires checking out mne-python branch https://github.com/mne-tools/mne-python/pull/12819
@mscheltienne I'm not sure what you mean by this
ah I see. but that is also controlled by the independent `mne.scale_factor` property. Currently the formula for displaying that text is (`self` is a `ScaleBarText` instance and `ch_type` is any...
Should this be fixed in https://github.com/mne-tools/mne-qt-browser/pull/268 or a separate PR?
I fixed this in commit https://github.com/mne-tools/mne-qt-browser/pull/268/commits/ee2d1aba5188003323aac897ad327ec845b080ce . It was an issue with how I was calculating scale. I wasn't using complete formula. It's now synchronized. I did find another error....
@wmvanvliet @larsoner I'm picking this up again. I have the vertical bar synced across databrowsers and time browse and channel browse seem to be working. I haven't worked on edge...
@wmvanvliet I added the `ChannelBrowse` and `TimeBrowse` ui events. Just need to make unit tests for them