crow icon indicating copy to clipboard operation
crow copied to clipboard

Added conan-based dependency management for the package.

Open cwolfe2 opened this issue 6 years ago • 4 comments

cwolfe2 avatar Apr 04 '19 00:04 cwolfe2

  • would need to modify appveyor environment to have conan installed
  • would need to have conan install step added, or done with external command in CMakeLists.txt
  • probably doesn't work out of the gate for x86, but x64 builds fine.
  • if you're interested, i can flesh out the other targets.

cwolfe2 avatar Apr 04 '19 00:04 cwolfe2

I like the idea of having the possibility to use Conan, but it should not be a prerequisite. Is it possible to have a CMakeLists.txt that uses Conan if it is available, but falls back to the current behavior if not?

nlohmann avatar Apr 04 '19 15:04 nlohmann

Sure. This is kinda lower priority for me right now, but I hope to circle back to it in the coming weeks. I’ll send you another PR then. ~Chris

From: Niels Lohmann [email protected] Sent: Thursday, April 4, 2019 11:53 AM To: nlohmann/crow [email protected] Cc: Christopher Wolfe [email protected]; Author [email protected] Subject: Re: [nlohmann/crow] Added conan-based dependency management for the package. (#37)

I like the idea of having the possibility to use Conan, but it should not be a prerequisite. Is it possible to have a CMakeLists.txt that uses Conan if it is available, but falls back to the current behavior if not?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/nlohmann/crow/pull/37#issuecomment-479955665, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Au-Zeu9_4JRkaGlREbJgqwQWqyjsq9Pmks5vdh_RgaJpZM4cbrV_.

cwolfe2 avatar Apr 04 '19 16:04 cwolfe2

Thanks a lot!

nlohmann avatar Apr 04 '19 16:04 nlohmann