nix-community
plugins/ltes-extra: support ltex_plus
ltex_extra reacently got support for ltex_plus, a more updated and still maintained fork of ltex (https://github.com/barreiroleo/ltex_extra.nvim/pull/66)
This PR adds support for both ltex, and ltex_plus, but defaults to using ltex_plus if neither is enabled. I've tried adding a warning of the change to notify users who depend on the implicit enabling of ltex.
I'm open to suggestions if there are other approaches to similar situations in Nixvim.
I've added options to the ltex_plus language server. Maybe I should split this into two PRs.
Tests previously failed due to ltex.enable not being masked properly. That is now fixed
I've added options to the
ltex_pluslanguage server. Maybe I should split this into two PRs.Tests previously failed due to ltex.enable not being masked properly. That is now fixed
First, thanks for the good work, this is looking great!
When it comes to option, I don't think that it is worth it to explicitly declare them.
It is already possible for users to put whatever they want in settings. It adds a maintenance load on Nixvim.
I would recommend to drop this part.
@nix-community/nixvim can someone double-check this PR please? Espacially the warnings logic.
Changes based on feedback.
Made the warning logic identify additional definitions of lsp.servers.ltex to those produced by nixvim modules. This may produce false positives as it doesn't take priority into account, but keeps it at a reasonable complexity.
The formatting is a bit awkward for the warning. I guess it's sufficient this for temporary code, however.