RB comments

Results 868 comments of

RB

Use Inline Policies instead of Managed

I agree with this too. It's far better to use inline if it's for a specific purpose otherwise the policies can be reused for other roles by mistake. Inline policies...

Stuck failed check if a non-existent directory or project is given

@lukemassa > Both cases add a failed atlantis/plan: my-directory/default check to the PR. Running a generic atlantis plan or planning a valid project/directory adds a successful overall atlantis/plan status, but...

Discover EFS FileSystemId instead of specifying it in storage class

Thank you @avanish23 for the pr to close my issue. Who is the right person to review this pr? cc @mskanth972 @dankova22

Improve installation

The suggestion is just to improve installation. The above are just suggestions to improve it. 😁

feat(aws_instance): add instance market options block

That new example directory isn't getting run by terratest. Was adding the example strictly as a way of documenting the feature? Here are some options worth considering 1. How come...

feat(aws_instance): add instance market options block

Thanks for addressing the changes. How come the _enabled flag is still used? I thought it was removed when this comment was raised? https://github.com/cloudposse/terraform-aws-ec2-instance/pull/202#discussion_r1719397421

feat(aws_instance): add instance market options block

/terratest

feat(aws_instance): add instance market options block

@haidargit see code annotations and test failures

feat(aws_instance): add instance market options block

Thanks for resolving some of the issues. There seem to be a few remaining. Please fix all of them and then resubmit the PR. I moved it to a draft...

feat(aws_instance): add instance market options block

I'll cc: @joe-niland here as I need help in reviewing the PR