RB comments

Results 868 comments of

RB

Optional user and password

I think we need a separated module for SSM / Secrets Manager like @jamengual mentioned. Then we can easily turn it on and off and have the variables located in...

Optional user and password

@arischow thanks for the suggestion. This PR is only for generating password credentials. Could you write that into a separate issue so we can track it?

security group: use for_each instead of count

We want to eventually migrate this module to using the security group module instead of the hard coded security group resources. This would also solve the count issue. https://github.com/cloudposse/terraform-aws-security-group

Optional or no egress rule in default security group

This is being worked on with major refactoring taking place in the https://github.com/cloudposse/terraform-aws-security-group module. Once the open PRs there are merged and this repo uses that module, then it will...

IAM policy is too loose

That's a great suggestion. We accept PRs and always welcome new contributors.

Use encryption at rest on bucket as default.

Yes that's a good idea as that would be more secure. We welcome pull requests. Please become a contributor if you feel strongly about this.

Error: cache location is required when cache type is "S3"

When you set `closes` and then the issue number in the PR, when the PR is merged, github will auto close the issue linked. I've reopened it for now.

Error: cache location is required when cache type is "S3"

Seems like this may be related https://github.com/hashicorp/terraform-provider-aws/issues/10195

Error: cache location is required when cache type is "S3"

What terraform versions are being used? The test uses 0.13 and I'm using 1.0 locally. Both seem to work as expected. How can I reproduce the issue?