ranch icon indicating copy to clipboard operation
ranch copied to clipboard
verified publisher icon ninenines

Extend error reason in case of failed handshake

Open Maria-12648430 opened this issue 1 year ago • 4 comments

Fixes #336.

Maria-12648430 avatar May 07 '24 11:05 Maria-12648430

About the pipeline failures in OTP 27: they happen because ct_helper apparently uses file:pid2name/1, which has been deprecated and removed in OTP 27.

Maria-12648430 avatar May 07 '24 12:05 Maria-12648430

No it's erlang.mk, it'll work if you make erlang-mk and commit the updated file.

essen avatar May 07 '24 12:05 essen

About the ssl_local_echo test currently failing for OTP 27, see https://github.com/erlang/otp/pull/8465

Maria-12648430 avatar May 08 '24 08:05 Maria-12648430

Added a test. Also made a change to obtain the peername early in the handshake, as it could happen that it is not available any more when an error happens.

juhlig avatar May 17 '24 12:05 juhlig

I have updated the CI, please force push to run CI again.

essen avatar Nov 06 '24 12:11 essen

Done. There is a failure in the shutdown suite (macOS, again :roll_eyes:) which seems to be a timing issue, in the test.

juhlig avatar Nov 11 '24 09:11 juhlig

Merged, thanks!

essen avatar Nov 12 '24 14:11 essen