ninadbstack

Results 29 comments of ninadbstack

We will take this as a feature request and get back to you. There is no ETA for this as of now.

@Kaedeko the feature is working as expected, its currently pass-if-approved and not pass until approved - with some timeout. `pass-if-approved` usually means no differences or auto approved due to some...

Thanks, apologies for the delay, will look into this next week. From my current understanding - we currently dont support this. We use storybook preview urls to load stories and...

Its probably not related to storybook file. Let me have a look but from glance it looks like something is breaking in the chromium CDP connection.

@jaysonwu991 can you create a small reproducible example for this ? where its clearly marked that commenting some import would cause percy to throw exception. So that we can reproduce...

@danieldelacruz01 Thanks for your contribution and I see why you might need that flag. I have added some comments on the PR. You can check the failing specs from the...

1. How is backwards compatibility maintained here ? 2. How does it work with non async supporting SDKs

`Non-JS SDKs never call PercyDOM.serialize() directly, percy CLI handles all browser interaction` this is not true - please check the sdks[ [ex](https://github.com/percy/percy-selenium-java/blob/master/src/main/java/io/percy/selenium/Percy.java#L519C9-L519C109)

@sharad-sharma hey, so I see that you still need to update this and its not ready. But just need to know why do you need to serialize external stylesheets ?...

@sharad-sharma I see, but then only external stylesheets wont help you here. There are many resources that needs to be captured and serialized. That said we dont recommend doing this...