EIPScanner icon indicating copy to clipboard operation
EIPScanner copied to clipboard

Add option to use 8 bit segments

Open contradict opened this issue 3 years ago • 2 comments

ConnectionManager passes through to the underlying MessageRouter.

contradict avatar May 11 '22 15:05 contradict

Hi, looking at this PR, I'm not sure I'd want to integrate this change.

If you need 8 bit segments when using a ConnectionManager for implicit requests, you can already construct a MessageRouter yourself, using the appropriate constructor. Although, it is shorter to type true than make_shared<MessageRouter>(true).

And then there is the question of encapsulation. The option to use 8bit segments is currently passed to and stored in the MessageRouter, but also passed to and stored in a MessageRouterRequest. Adding the option here would add to the maintenance overhead; e.g.: should the option ever be renamed, or should the MessageRouter change it's constructor.

JohannesKauffmann avatar Jul 31 '22 22:07 JohannesKauffmann

@Broekman Do you have any strong opinions?

JohannesKauffmann avatar Aug 02 '22 19:08 JohannesKauffmann