nima200
Not really an issue but:
I added button so that we can navigate to dashboard by clicking the Title in the navbar. I upgraded the angular cli to current version (9). Angular.json has been created, replacing angular-cli.json.
Hope I can create a pull request. I was trying but I could not.
Here is my cloned version of your repo: [https://github.com/IamGiel/forking-dynamic-reusable-responsive-components]
Thanks, Gel
Hey Gel (Giel? Pardon me if I'm typing your name wrong, basing it on your footnote),
It seems like GitHub repository you've linked which I took a look at in your profile is not an official fork of this repository.
You do however have another repository which is, but it seems like your changes are not on top of that one.
To create a pull-request, you need to do it on the one that indeed is a fork.
Please see the following images:
As you can see in the first image, the repository IAmGiel/angular-dashboard is marked as a fork by GitHub and will be able to be placed in a pull request while IamGiel/forking-dynamic-reusable-responsive-components is not.
Looking forward to reviewing your PR once you've managed to cherry-pick your changes to IAmGiel/angular-dashboard!
Thank you for your contribution, Nima
Nima,
Gel is fine :)
I will add changes on the forked repository then make a PR. I am studying your work so I can apply it on my current project. I still yet to understand how your able to achieve that effect where the cards created new rows as the screen decrease in size. Hope I can ask you for some help as I work to re-create your approach on my project.
I am applying this to this page I am working on: https://demobotproject.firebaseapp.com/bot/portfolio
Thanks for your contribution to the community.
Best, Gel
On Fri, Mar 6, 2020 at 11:37 PM Nima Adibpour [email protected] wrote:
Hey Gel (Giel? Pardon me if I'm typing your name wrong, basing it on your footnote), It seems like GitHub repository you've linked which I took a look at in your profile is not an official fork of this repository. You do however have another repository which is, but it seems like your changes are not on top of that one. To create a pull-request, you need to do it on the one that indeed is a fork. Please see the following images: [image: image] https://user-images.githubusercontent.com/16521944/76136759-0939f280-5fea-11ea-8328-accb2c3ab14a.png [image: image] https://user-images.githubusercontent.com/16521944/76136764-122ac400-5fea-11ea-9931-54397b13f46e.png As you can see in the first image, the repository IAmGiel/angular-dashboard is marked as a fork by GitHub and will be able to be placed in a pull request while IamGiel/forking-dynamic-reusable-responsive-components is not.
Looking forward to reviewing your PR once you've managed to cherry-pick your changes to IAmGiel/angular-dashboard!
Thank you for your contribution, Nima
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nima200/angular-dashboard/issues/5?email_source=notifications&email_token=AHFKNE6QINRGVMA36L7ESETRGHFQLA5CNFSM4LDDAHW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEODPAIA#issuecomment-596045856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFKNE3PQSS6VBDOELFKDILRGHFQLANCNFSM4LDDAHWQ .
-- About Gel ☕️ Here. https://www.linkedin.com/in/geldeasis/