react-native-pie icon indicating copy to clipboard operation
react-native-pie copied to clipboard
verified publisher icon nihgwu

a proposed fix to the strokeCap issue number #44

Open SiyabongaNzulwana opened this issue 5 years ago • 5 comments

As I have mentioned that I was facing an issue with the strokeCap={'round'} prop, I was able to figure out what the issue might be, and I decided to push a PR for the proposed fix. NB: this is happening on "version": "1.1.2".

This is related to issue number #44

Screenshot 2020-08-24 at 16 58 08

SiyabongaNzulwana avatar Aug 27 '20 16:08 SiyabongaNzulwana

I think this will break this use case: round

After applying your changes I see this:

roundbroken

You also have merge conflicts as I just merged https://github.com/nihgwu/react-native-pie/pull/40 which ran prettier on the Pie.js file.

zgordon01 avatar Sep 03 '20 05:09 zgordon01

@SiyabongaNzulwana ready for review again?

zgordon01 avatar Sep 09 '20 13:09 zgordon01

@zgordon01 Yes, its ready...

SiyabongaNzulwana avatar Oct 10 '20 13:10 SiyabongaNzulwana

This same line is currently causing our app to crash because the is no const before the variable name. Would you consider updating this, and then @nihgwu can we get this merged in?

My guess is this repo is abandoned at this point, but hopeful!

CarolynWebster avatar Apr 26 '22 20:04 CarolynWebster

@CarolynWebster Sorry I don't use RN for years, but if you can confirm this PR works, I'll update your propose directly and merge it

nihgwu avatar Apr 26 '22 22:04 nihgwu