nightscout
AutoISF plugin prototype
According to the hint given in the earlier submission (#3206) this version has AutoISF completely contained in its own plugin.
It represents AutoSF version 3.0 as described in https://github.com/ga-zelle/autoISF/blob/A3.2.0.2_ai3.0/autoISF3.0_Quick_Guide.pdf. However, some functionality was not yet included, namely
- no dedicated automations
- no activity monitor based on step counting
- no home screen adaptations
AutoISF version 3.0.1 is in its final testing. Once verfied it will be added and offers a reduced set of preferences and flatter preference menus.
The code was tested
- by unit tests of its basic functions. The AutoISF function itself needs more work.
- test json's were added to ReplayApsResuiltsTest. One test failed due to minor deviation of eventualBG 103 vs. 104. Most likely this was due to unfortunate rounding in determine basal code (js and kt versions).
- observing test runs and verifying results against my AAPS emulator
A big thank you goes to @Philoul . Not only did he create the plugin structure but he also put in considerable work to align the architecture as much as possible with DynamicISF. This resulted in some code duplication but AutoISF is independent of the remaining code and can be tested and developed independantly.
make it available in engineering mode only for now (see Autotune plugin)
make it available in engineering mode only for now (see Autotune plugin)
You are right, I forgot to included it in the new proposal (I made a PR to ga-zelle branch, with engineering mode + dev branch like autotune).
Quality Gate failed
Failed conditions
35.4% Duplication on New Code (required ≤ 3%)
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
5 preferences were deleted and the related flatter menus from AutoISF 3.0.1 standalone are now updated to this PR.
Thank you to @Philoul for pointing out a commit that should not have slipped in yesterday - and for great help in getting rid of it.
it's doesn't touch other code now so: add to plugin
override fun specialEnableCondition(): Boolean = config.isEngineeringMode() && config.isDev()
and I'll merge it to simplify your life
Quality Gate failed
Failed conditions
42.2% Duplication on New Code (required ≤ 3%)
See analysis details on SonarCloud
Does this includes the new 1 minute libre capability? And the dedicated automations? This is a great addition.
