AndroidAPS icon indicating copy to clipboard operation
AndroidAPS copied to clipboard
verified publisher icon nightscout

UI: Graph Scale Buttons instead of Dropdown

Open kenzo44 opened this issue 1 year ago • 3 comments

An alternative solution to https://github.com/nightscout/AndroidAPS/pull/3306 - instead of having text overlayed on the graph, added buttons to switch between scales.

Users can tap on buttons to quickly switch between graph scales instead of doing it with 3 actions. This will also make the dropdown exclusively for graph data management.

Todo:

  • Remove graph scale from the dropdown menu
  • Remove long tap on graph to switch between graph scales

kenzo44 avatar Apr 28 '24 00:04 kenzo44

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 28 '24 00:04 sonarqubecloud[bot]

Nice...

Q: Looks like this PR was based on dev + PR#3306? Merging PR#3311 on top of PR#3306 results in a merge conflict... 🤔

vanelsberg avatar Apr 28 '24 19:04 vanelsberg

Merge with current dev. Works without issues. Nice!

vanelsberg avatar May 02 '24 19:05 vanelsberg

Final proposal (clean PR) done here #3347

Philoul avatar May 24 '24 14:05 Philoul