pyhss icon indicating copy to clipboard operation
pyhss copied to clipboard
Published 3 months ago • verified publisher icon nickvsnetworking

Implement proper SQN

Open osmith42 opened this issue 2 months ago • 3 comments

This PR will fix #266. I've tested it with 3G and subscribers were able to attach.

There is still a lot to do before this is ready to merge, but sending the PR already in case somebody is curious about how I plan to implement this.

TODO:

  • [x] As this must change the database layout: implement automatic database upgrades first, in a separate PR (see #267) (will split this out into a separate PR)
    • [ ] this is now in #297. The PR here needs to be rebased on top.
  • [x] Store separate SEQ per IND+subscriber combination? (see OS#6894)
  • [ ] More testing

CC @Takuto88 in case you want to have a look and have comments already, but a thorough review is not needed as this is still very WIP.

osmith42 avatar Dec 01 '25 09:12 osmith42

This is still a draft, but I've now added automatic database updates (will clean this up some more and make a separate PR) and storing SEQ numbers for each subscriber + IND combination. The latter also needs some more cleaning up, resolving some fixmes, etc., but from my testing with a 3g network it is already working as expected.

osmith42 avatar Dec 16 '25 15:12 osmith42

Uuuh ... very nice. I'll definitly take a look at this as soon as I can. That's some great news :tada:

Takuto88 avatar Dec 16 '25 16:12 Takuto88

Uuuh ... very nice. I'll definitly take a look at this as soon as I can. That's some great news 🎉

Thanks :slightly_smiling_face: still no need for a thorough review yet, I'm currently splitting out and cleaning up the DB upgrade logic (for a separate PR), so there will be some more changes.

osmith42 avatar Dec 17 '25 15:12 osmith42