honcho icon indicating copy to clipboard operation
honcho copied to clipboard

Proper Handling of SIGINT/SIGQUIT

Open claymation opened this issue 11 years ago • 4 comments

In researching #70, I ran across Proper Handling of SIGINT/SIGQUIT, which recommends that if a child execed by honcho run exits due to SIGINT, Honcho should kill(SIGINT) itself in order to properly terminate shell scripts that may have invoked Honcho.

It's a fascinating, if long-winded article, but the premise is that the child should determine how to handle SIGINT, and parents (while ignoring SIGINT themselves), should honor the child's decision if it decides to exit by propagating the SIGINT exit status back up the ancestor chain to the shell.

claymation avatar Oct 16 '14 13:10 claymation

Control-C now is not making the server exit as before :(

ghost avatar May 26 '15 02:05 ghost

I realized, that when I kill the honcho start process with ctrl-c, the children keep on running - this is somehow the other way round than this issue. Is there something to prevent this, and kill all spanned processes? Thanks!

chaosmail avatar Jun 04 '15 17:06 chaosmail

Any updates on this?

chaosmail avatar Sep 15 '15 15:09 chaosmail

@chaosmail Maybe you're referring to the change in #84. In that change, honcho run will ignore SIGINT, allowing the child to handle that signal as it will. I don't believe that change had any impact on honcho start, however.

This issue (#85) is simply a request for enhancement to follow best practices when a child exits due to SIGINT. It's probably not the issue you're looking for.

claymation avatar Sep 15 '15 18:09 claymation