Nick Janetakis
Nick Janetakis
What if it worked naturally when `root` isn't defined in the vhost? You could test if `root` is defined, instead of the custom variable. Then it works without additional configuration...
It should work. It's what I'm running in production right now. I have 3 domains on 1 server, all with their own vhost config, each redirecting from www to non-www....
Yes they are all using the same certificate, but each site also has its own vhost config, which in turn has its own SSL configuration, so I'm not seeing why...
Shouldn't bar.com's vhost config have its own config which has bar's certificate? That redirect would also only be valid for bar.com, not foo.com (it wouldn't even match for foo.com due...
Ok I see. I forgot, the redirect is listening on port 443 (I thought it was on port 80), and the port 80 redirect to 443 is already happening prior...
Since it's "just" a redirect, I wonder if we can get by with just duplicating the 3 SSL certificate values, rather than everything. It should be safe to inherit the...
For correctness and less "wtf is happening" it might be best to duplicate them all. But please let me know if it works (if you duplicate them all) once your...
In the end, having support for your modifications seems reasonable. It's not what I do personally, but I imagine a lot of other people would be interested. And there's been...
Hi, Thanks for the PR, and you are correct. I reviewed the docs and yep, you can't have both an upstream and code defined like that. The code approach works...