nichmor

Results 59 comments of nichmor

> I meant a `rattler_build.conda_build_compat` module. I didn't know that rattler-build didn't have a python API. Still, I don't think we should be maintaining this code in conda-smithy. Maybe a...

> May have missed this earlier, but with `conda smithy init` are we adding a flag to allow configuring whether `conda-build` or `rattler-build` is used? Or how is that handled?...

> Thanks for the info! 🙏 > > > during the execution of `conda smithy init` it will try to load first the `meta.yaml`. If it's not present, it switch...

hey @isuruf I would like to ask for review again : I've implemented missing linting checks and extracted all rattler-build related code to rattler-build-conda-compat. hey @jakirkham ! I wanted to...

hey @beckermr ! Additional templates were removed - so now we are extending existing ones. Let me know what do you think Thank you.

> Please rerender an existing feedstock that was rendered with latest released conda-smithy and make sure that there was no change. hey @isuruf ! This is the result: https://github.com/nichmor/rattler-build-feedstock/pull/1 https://github.com/nichmor/py-rattler-feedstock/pull/1...

hey @isuruf @beckermr ! I wanted to ask if there is anything else that need to be changed or improved. Thank you!

> I like it! Maybe we can rename it `LocalArchive` to indicate that its a file on disk. There is also a lot of `//test` in the code. Could you...

> I like it! Maybe we can rename it `LocalArchive` to indicate that its a file on disk. There is also a lot of `//test` in the code. Could you...